Repository navigation
Build robustness: pinned meteo stations, execute notebooks once, conduct contact - #5
Merged
Merged
Conversation
…on lookups Download Agrometeo data from station 239 (Meggen) for a fixed past week instead of feeding find_nearest_station() into download_data(), and show download_data_by_plz() as a non-executed example. The lookups are still demonstrated; MeteoSwiss already uses the fixed station LUZ. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Switch execute_notebooks to "cache" so the HTML build after the PDF build (and local rebuilds) reuse the executed outputs from _build/.jupyter_cache instead of relying on the Sphinx environment. A failing notebook still fails the -W build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reports go to the maintainer via GitHub: privately with "Report content" (to repository admins) or GitHub's abuse reporting, otherwise in a discussion. No email address. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-ups to make the book build more robust.
Changes
LUZ. Thefind_nearest_station()lookups are still shown, but their result is not used for the download.download_data_by_plz()is shown as a code example that is not executed. Checked by running: 168 hourly rows, 4 sensors (global radiation is missing at night, as before).execute_notebooks: cache. The first build stores the executed notebooks inedap/_build/.jupyter_cache, the second one (HTML after PDF) reuses them. Before, this only worked because Sphinx reused its pickled environment; any config difference between the two builds would have re-executed everything. The runner starts empty, so PR, weekly and deploy runs still execute every notebook against the live data sources. A failing notebook still fails the-Wbuild (tested with a notebook that raises an error).Local checks
_buildwith execution and-W --keep-going: 0 warnings, about 100 s.singlehtmlthenhtml: the notebooks execute once (104 s), and the second build takes 3 s. A rebuild that re-reads all sources (--all) uses the cache: 0 executions, 5 s._config.ymlparse as YAML.🤖 Generated with Claude Code