Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #145
Per RFC 3261 (§16.7, §17.1.1.3), the ACK for a 2xx final response is
end-to-end and generated by the UAC, so a proxy must not send one
itself. This change stops the proxy from ACKing 2xx responses; ACKs for
non-2xx final responses are unchanged.
Verified with cargo fmt, cargo build, cargo test (all passing), and
cargo clippy --lib (no new warnings).
Note: cargo clippy --lib reports one pre-existing warning (drop_non_drop,
src/dialog/invitation.rs), also present on v0.6.6; unrelated and left untouched.