Skip to content

Use libsoup 2.4 and remove the souphttpsrc patch - #85

Merged
neodesys merged 1 commit into
masterfrom
use-libsoup-2.4
Jul 8, 2026
Merged

Use libsoup 2.4 and remove the souphttpsrc patch#85
neodesys merged 1 commit into
masterfrom
use-libsoup-2.4

Conversation

@neodesys

@neodesys neodesys commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes

    • Improved streaming reliability during seeking, flushing, and looping playback to reduce intermittent playback errors.
    • Fixed a race condition that could cause repeated requests to reuse stale state.
  • Chores

    • Updated build and runtime dependencies to align with the newer compatible Soup 2.4 stack.

@neodesys neodesys self-assigned this Jul 8, 2026

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c60f7d2d-f63a-4e9f-9c41-f22d1bbaa15f

📥 Commits

Reviewing files that changed from the base of the PR and between 4dd3ea0 and 6e114e5.

📒 Files selected for processing (4)
  • Dockerfile-prod-base.in
  • docker/build-gstreamer/compile
  • docker/build-gstreamer/install-dev-dependencies
  • docker/build-gstreamer/patch/gstreamer/0004-souphttpsrc-fix-race-conditions-when-looping.patch
💤 Files with no reviewable changes (2)
  • docker/build-gstreamer/compile
  • docker/build-gstreamer/patch/gstreamer/0004-souphttpsrc-fix-race-conditions-when-looping.patch

📝 Walkthrough

Walkthrough

This PR reverts the libsoup dependency from version 3.0 to 2.4 in the production base Dockerfile and GStreamer dev dependencies script, and removes the previously applied souphttpsrc race-condition patch and its application step from the GStreamer build script.

Changes

libsoup 2.4 downgrade

Layer / File(s) Summary
Update libsoup package references
Dockerfile-prod-base.in, docker/build-gstreamer/install-dev-dependencies
Replaces libsoup-3.0-0 with libsoup-2.4-1 and libsoup-3.0-dev with libsoup2.4-dev in the respective apt-get install lists.
Remove libsoup race-condition patch application
docker/build-gstreamer/compile, docker/build-gstreamer/patch/gstreamer/0004-souphttpsrc-fix-race-conditions-when-looping.patch
Removes the git apply step for the souphttpsrc race-condition patch and deletes the patch file entirely.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: switching to libsoup 2.4 and removing the souphttpsrc patch.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch use-libsoup-2.4

Comment @coderabbitai help to get the list of available commands.

@neodesys
neodesys requested a review from ArmorDarks July 8, 2026 14:28
@neodesys
neodesys merged commit e46dfff into master Jul 8, 2026
5 checks passed
@neodesys
neodesys deleted the use-libsoup-2.4 branch July 8, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants