Repository navigation
fix(js): the package metadata, and two things it got wrong - #19
Merged
Merged
Conversation
Published 0.1.0 and then read package.json properly. Two real errors: - README said the package is MIT. It is Apache-2.0, in package.json and in LICENSE. A licence claim in the file people actually read. - js/ had no LICENSE or NOTICE, so the published tarball carries neither. Same bug PR #18 fixed for core; I had only looked at core. package.json gains homepage, repository (with directory: js, so npm knows it is a monorepo subfolder), bugs and keywords -- the GitHub link and keyword search the npm page was missing. A files list drops the two test files from the tarball and adds the licences. The README is the npm page now, so every relative link is absolute: they all 404 on npmjs.com. 'To publish, run npm publish' is gone, since CI builds it and it is already published. The licence drift test now covers js/ as well as core/. Verified with npm pack --dry-run (5 files, tests out, licences in) and by tampering with js/NOTICE, which fails it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Published
0.1.0to npm, then readjs/package.jsonproperly. Two real errors, plus the metadata that was missing.Two bugs
The README claimed the wrong licence.
package.jsonandLICENSEboth say Apache-2.0. That line said MIT — a licence claim in the file people actually read.js/had noLICENSEorNOTICE, so the tarball now on npm carries neither. Same bug #18 fixed forcore/; I'd only looked at core at the time.package.json: 245 → 723 bytesAdded
homepage(→js/),repositorywith"directory": "js"so npm knows it's a monorepo subfolder,bugs, andkeywords. That's the GitHub link and keyword search the npm page currently lacks —npm view docsignershows no repo at all.A
fileslist fixes what ships:docsigner.js,README.md,package.jsontest/*.test.jsLICENSE,NOTICEAlso widened the description — "Browser library for the DocSigner document signing stack" doesn't say what it does. Now "Sign PDFs in the browser with a DSC token."
README
It's the npm project page now, so it was rewritten for that reader:
npm install docsignerup front, and every relative link made absolute —../CONTRACTS.mdand friends all 404 on npmjs.com. The stale "to publish, runnpm publish" section is gone, since CI builds the tarball and it's already published. Contributor bits below a divider.Verified
npm pack --dry-run→ 5 files, tests out, licences injs/as well ascore/— 128 tests, up from 126 — and tampering withjs/NOTICEfails itnode --testgreenNote
npm freezes metadata per version, so the live
0.1.0page keeps what it has. All of this appears when0.1.1publishes.