Repository navigation
Conversation
Author
|
So far I just noticed that https://www.npmjs.com/package/tsc-alias can inject file extensions automatically:
[edit]: but typecheck won't allow missing file extension in import/export instructions by default :( |
Author
|
Closing in favor of #677 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix esm build
Related Issue
#672
Screenshots / Recordings
Notes for Reviewers
This is a PoC in its current state.
It only changes:
module: ts and node sees it as esm packagefrom "@/components/Alert"become"@/components/Alert/index.js"More details in this post: https://gist.github.com/slavafomin/cd7a54035eff5dc1c7c2eff096b23b6b
Currently the transitives are suffering of the same issue, so there is still work to do:
Let me know if you want me to finish this PR or if you have any suggestions.