Repository navigation
Blueprint: env groups for secrets, unpin the workflow repo - #71
Merged
Merged
Conversation
The secrets move into two environment groups: vibe-factory-shared holds RENDER_API_KEY for both services, and vibe-factory-workflow-secrets holds the model key, GitHub credential, APPS_REPO, and workspace ID for the workflow service only. The workflow service drops its repo field, so it builds the repository that holds the Blueprint, as the gateway does. Closes #48 Closes #69 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48 and #69 together, since both rewrite
render.yaml. This is a draft until someone deploys it from a fork (checklist below).#69 Environment groups
vibe-factory-sharedholdsRENDER_API_KEYand is attached to the gateway and the workflow service.vibe-factory-workflow-secretsholdsAPPS_REPO,RENDER_WORKSPACE_ID,ANTHROPIC_API_KEY, and the GitHub credentials, and is attached only to the workflow service. The issue proposed naming itvibe-factory-workflows, but that is already the workflow service's name.DATABASE_URL,FACTORY_API_KEY,RENDER_WORKFLOW_SLUG,UI_USERNAME, andUI_PASSWORDstay on their services.fromGroup. The Blueprint schema allows it, andrender blueprints validateaccepts this file.doctorand.env.exampleneeded no change, because they read the local.env. The Quickstart, README, AGENTS.md, and extension guide are updated.#48 Workflow repo
repo:from the workflow service. The schema says an omittedrepomeans the repository that holds the Blueprint, which is how the gateway already works.fc278a9added the pin without saying why, so this needs a real deploy to confirm.repo:" instructions from the README, Quickstart, and AGENTS.md.Before merge, someone must
Note for factories already deployed
Syncing this Blueprint creates the groups but doesn't remove the existing per-service values. Render gives a service's own value priority over a group value, so delete the old per-service secrets from both services after the sync, or rotating a key in a group won't take effect.
Testing
render blueprints validate render.yamlis valid and plans to create the 2 env groups.check-jsonschemaagainst the published schema passes.npm run checkpasses.Made with Cursor