Skip to content

Isolate workflow tests from user deployment configuration - #80

Open
starmorph wants to merge 1 commit into
render-examples:mainfrom
starmorph:codex/independent-test-config
Open

starmorph wants to merge 1 commit into
render-examples:mainfrom
starmorph:codex/independent-test-config

Conversation

@starmorph

Copy link
Copy Markdown
Contributor

Valid edits to factory.config.ts could break the template's own tests: a single verification command threw during test collection, while a non-main branch failed hardcoded assertions. Tests across routing, claims, cancellation, and workflows also derived their subjects from mutable operator settings.

Vitest now replaces the deployment file at its module boundary with explicit test fixtures. The real application configuration resolver, permissions, publishing, and cleanup code remain in use. Added behavior cases select different repositories and branches with empty, single, and three-command verification lists, checking draft publishing and COMMENT review behavior. Contributor guidance identifies fixture ownership.

Developers can customize their deployment without reshaping valid configuration to satisfy template test assumptions. No production runtime behavior changed and existing authority/security assertions remain effective.

Validation: npm run check passed — 26 files, 176 tests. The complete check also passed with five temporary deployment configurations: single verify, empty verify, three verify commands, master, and multiple repositories with distinct non-main branches. Each variant additionally changed labels, prefix, required permission, limits, and timeout. The original deployment file was restored byte-for-byte; the lockfile is unchanged.

Fixes #76.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

[P1] Decouple workflow tests from user deployment configuration

1 participant