Repository navigation
Conversation
Validate Render task responses, fail incomplete registration and installation grants, and distinguish webhook configuration from proven delivery. Require delivery metadata for the configured target without claiming current activation. Fixes render-examples#75
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doctor could exit successfully with zero registered tasks, an unavailable task API, or missing effective installation grants. A successful JSON
nulltask response also crashed the check. Separately, GitHub setup treated an old failed delivery attempt as proof that the webhook was delivering, even while inactive.Required task checks now fail when registration is missing, incomplete, unavailable, or invalid. Zod validates external task responses and webhook delivery metadata without printing raw payloads. Missing installation permissions/events also fail readiness. The gateway's intentional no-App-credentials skip remains supported.
Webhook setup now states that configuration succeeded while activation/delivery remains unverified. Doctor checks the documented delivery-detail URL against the configured gateway and requires a successful response, with instructions to activate/save and redeliver a ping when needed. It reports the observed delivery rather than claiming the App is currently active, and imposes no arbitrary age cutoff. Runbook and operational guidance match that behavior.
Users and automation can now treat failed or unavailable required checks as blockers, rather than mistaking a zero exit for verified readiness.
Validation:
npm run checkpassed — 26 files, 191 tests. Added fake-backed coverage for null/malformed/non-array task payloads, unavailable/rejected APIs, zero/partial/complete tasks, missing grants, expected gateway skips, and missing/failed/mismatched webhook delivery metadata. No deployed resources or live credentials were changed.Fixes #75.