Repository navigation
Save generated GitHub App credentials securely by default - #78
Merged
jacobprall merged 1 commit intoOct 28, 2026
Merged
Conversation
jacobprall
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
npm run setup:appwithout--write-envpreviously printed the generated GitHub App private key and webhook secret into terminal output. Updating an existing.envcould also preserve broader file permissions, leaving new secrets under the file's previous access mode.Setup now always saves credentials to
.envand reports only their names and destination. Existing POSIX files are restricted to0600before secrets are written; new files retain owner-only permissions. The documented--write-envoption remains accepted, and the runbook explains the secure default.This makes the normal onboarding command safe without requiring developers to know an optional flag. The manifest, installation steps, and separation of gateway/Workflows credentials are preserved.
Validation:
npm run checkpassed — 27 files, 171 tests. Four new regression tests use fake manifest credentials and temporary files to cover default and legacy command output, saved values, and owner-only permissions on new/existing files. No live credential or service calls were used.Fixes #74.