Repository navigation
Conversation
Collaborator
|
Closing in favor of an upstream fix. The diagnosis is right: connect-token requests ignore the caller's signal, and terminate has no budget. But a custom
Thanks for the thorough repro, which is quoted in the SDK issue. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK's initial connect-token requests currently ignore operation signals, and cleanup can wait indefinitely after an answer is computed. Supply the public
SandboxesClientwith an owned typed HTTP transport that carries cancellation into control/token requests and response-body reads. Bound pacing, retries, file transfers, stream waits, workspace lookup, and termination.Default calls/control requests have a 30-second budget; termination has an independent 10 seconds. Exec streams retain their workload deadline. A late create ID retains a cleanup observer with a fresh budget. If cancellation prevents receiving an ID, the remote outcome remains unknown and the mandatory provider lifetime remains the backstop; emit
sandbox_create_unknown. Retry create only after a known rejection such as 429.Preserve SDK authentication, workspace/region selection, user-agent, error decoding and data-plane signals. SDK stays pinned at 1.3.0; the already locked
openapi-fetch0.15.2 becomes an explicit dependency. No global fetch replacement or private SDK access is used in production. The token gap also remains in the verified SDK 1.5.0 source.Validation:
No live Render deployment or paid-provider validation was performed. Unknown remote create outcomes remain explicitly documented rather than treated as confirmed cleanup.
Fixes #26.