Repository navigation
Separate question ID signing from caller authentication - #30
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bearer-token holders can currently sign arbitrary workflow run IDs and use the API to poll or follow up on runs it did not start. Sign question IDs with a required, API-only
QUESTION_ID_SECRET, independent ofAPI_TOKEN, and reject invalid signatures before accessing workflows.The Blueprint generates the new secret. Existing deployments must configure a distinct secret of at least 32 characters before upgrading; old question IDs become invalid. Keep this secret stable across API replicas and restarts. Rotating only the bearer token preserves ID signatures.
Validation:
git diff --checkpassed.Fixes #20.