Repository navigation
Launch review: module cleanup, new docs, and a behavior-focused test suite - #17
Merged
Merged
Conversation
- Split src/types.ts into question, investigation, manifest, bot-config, util, runner/protocol, and runner/providers modules - Split src/slack.ts into src/slack/ (events, client, transcript, format, routes) - Break the runner's main/session import cycle with runner/events.ts and runner/model.ts - Log everything through createLog, including the sandbox client and cron - Make SANDBOX_PROVISION_TIMEOUT_MS bound opening an investigation Sandbox - Rename the internal network policy to the API's type/domains vocabulary - Log the runner's failure message when an investigation fails - Fail the snapshot build when the runner can't be confirmed non-dumpable - Fix the API build filter, stale comments, shadowed config, and banners Co-authored-by: Cursor <cursoragent@cursor.com>
Fold docs/design.md, docs/sandboxes.md, and docs/channels.md into the new docs, and narrow the README to what it is, why it matters, and getting running. Co-authored-by: Cursor <cursoragent@cursor.com>
Test through public entry points (HTTP routes, workflow tasks, sandbox providers, the runner CLI) and keep the security-relevant properties; drop tests of private helpers, exact strings, and duplicate cases. Co-authored-by: Cursor <cursoragent@cursor.com>
…race id Correct the docs where they drifted from the code, cut duplication between QUICKSTART and WALKTHROUGH, document investigation_failed and the build's non-dumpable check, and note that render workflows dev loads .env. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Oct 19, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the template in line with the launch checklist (code review and docs).
Code
src/types.tsinto focused modules:question.ts(public API contract),investigation.ts,manifest.ts,bot-config.ts,util.ts,runner/protocol.ts,runner/providers.ts.src/slack.tsintosrc/slack/(events, client, transcript, format, routes).main.ts/session.tsimport cycle withrunner/events.tsandrunner/model.ts.createLogacross the API, Slack adapter, sandbox client, and cron. Event names and fields are unchanged; every line now also carrieslevelandmsg.SANDBOX_PROVISION_TIMEOUT_MSnow actually bounds opening an investigation Sandbox (restore, boot,verify.sh, manifest read). Before, it only padded the task timeout.type/domainsnames;wirePolicyis still the single conversion point.investigation_failedwith the runner's (redacted) message, so a bad model key isn't invisible.buildFilterinrender.yaml(it pointed at the deletedsrc/slack.tsand missedsrc/log.ts), stale comments, a shadowedconfig, and the decorative banners.Docs
README.mdis now focused on what it is, why it matters, and getting running (100 lines, down from ~500).docs/QUICKSTART.md(setup, deploy, Slack, local dev, customizing, config reference, operations),docs/WALKTHROUGH.md(architecture, layout, question API, workflow, sandboxes, runner, security boundary), anddocs/TAKEAWAYS.md(reusable patterns).docs/design.md,docs/sandboxes.md, anddocs/channels.mdare folded into the new docs and removed. Several claims in them that no longer matched the code were corrected.Tests
pnpm typecheckandpnpm testpass locally.Made with Cursor