Repository navigation
Internal: Fix double AudioContext close in keep-alive test - #12704
Merged
Merged
Conversation
Contributor
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Removes the manual
audioContext.close()from the keep-alivetest.eachcase inpackages/media/src/test/audio-anchor-reschedule.test.tsx. ThePlayernow closes its sharedAudioContextin theuseSingletonAudioContextcleanup on unmount (added inbb009af2f9), so the test's post-root.unmount()close was racing it intoInvalidStateError: Cannot close a closed AudioContext. Since thePlayerowns the context's lifetime, dropping the redundant close is the right fix — the variable is still used above for the null check, so nothing is left unused.
deepseek-v4.1-flash | 𝕏
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

#12634 made
<Player>close its sharedAudioContexton unmount. The keep-alive tests added in #12609 (merged around the same time) still close that same context afterroot.unmount(), which can throwInvalidStateError: Cannot close a closed AudioContext.Seen on macOS CI in #12695: https://github.com/remotion-dev/remotion/actions/runs/40857074509
The Player now owns closing the context, so the test no longer closes it.