Skip to content

@remotion/cli: Respect --flag false for 7 boolean options #12629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DeryFerd wants to merge 1 commit into
base: main
Choose a base branch
from
Open

@remotion/cli: Respect --flag false for 7 boolean options #12629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/cli/src/parsed-cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,11 @@ const {
previewSampleRateOption,
rspackOption,
skipSkillsOption,
throwIfSiteExistsOption,
enableCrossSiteIsolationOption,
preferLosslessOption,
enableLambdaInsights,
askAIOption,
}: typeof BrowserSafeApis.options = BrowserSafeApis.options;

export type CommandLineOptions = {
Expand Down Expand Up @@ -276,6 +281,13 @@ export const BooleanFlags = [
bundleCacheOption.cliFlag,
rspackOption.cliFlag,
skipSkillsOption.cliFlag,
throwIfSiteExistsOption.cliFlag,
enableCrossSiteIsolationOption.cliFlag,
preferLosslessOption.cliFlag,
enableMultiprocessOnLinuxOption.cliFlag,
folderExpiryOption.cliFlag,
enableLambdaInsights.cliFlag,
askAIOption.cliFlag,
];

export const parsedCli = minimist<CommandLineOptions>(process.argv.slice(2), {
Expand Down Expand Up @@ -306,6 +318,11 @@ export const parsedCli = minimist<CommandLineOptions>(process.argv.slice(2), {
[mutedOption.cliFlag]: null,
[enableCancellationOption.cliFlag]: null,
[rspackOption.cliFlag]: null,
[enableCrossSiteIsolationOption.cliFlag]: null,
[enableMultiprocessOnLinuxOption.cliFlag]: null,
[folderExpiryOption.cliFlag]: null,
[enableLambdaInsights.cliFlag]: null,
[askAIOption.cliFlag]: null,
},
}) as CommandLineOptions & {
_: string[];
Expand Down
2 changes: 1 addition & 1 deletion packages/renderer/src/options/ask-ai.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export const askAIOption = {
docLink: 'https://www.remotion.dev/docs/options/disable-ask-ai',
type: false as boolean,
getValue: ({commandLine}) => {
if (commandLine[cliFlag] !== undefined) {
if (commandLine[cliFlag] !== undefined && commandLine[cliFlag] !== null) {
askAIEnabled = false;
return {
value: askAIEnabled,
Expand Down
4 changes: 2 additions & 2 deletions packages/renderer/src/options/cross-site-isolation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ export const enableCrossSiteIsolationOption = {
docLink: 'https://www.remotion.dev/docs/options/cross-site-isolation',
type: false as boolean,
getValue: ({commandLine}) => {
if (commandLine[cliFlag] !== undefined) {
if (commandLine[cliFlag] !== undefined && commandLine[cliFlag] !== null) {
return {
value: commandLine[cliFlag] as boolean,
value: Boolean(commandLine[cliFlag]),
source: 'cli',
};
}
Expand Down
4 changes: 2 additions & 2 deletions packages/renderer/src/options/enable-lambda-insights.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ export const enableLambdaInsights = {
option = value;
},
getValue: ({commandLine}) => {
if (commandLine[cliFlag] !== undefined) {
if (commandLine[cliFlag] !== undefined && commandLine[cliFlag] !== null) {
return {
value: commandLine[cliFlag] as boolean,
value: Boolean(commandLine[cliFlag]),
source: 'cli',
};
}
Expand Down
4 changes: 2 additions & 2 deletions packages/renderer/src/options/enable-multiprocess-on-linux.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ export const enableMultiprocessOnLinuxOption = {
docLink: 'https://www.remotion.dev/docs/options/enable-multiprocess-on-linux',
type: false as boolean,
getValue: ({commandLine}) => {
if (commandLine[cliFlag] !== undefined) {
if (commandLine[cliFlag] !== undefined && commandLine[cliFlag] !== null) {
return {
source: 'cli',
value: commandLine[cliFlag] as boolean,
value: Boolean(commandLine[cliFlag]),
};
}

Expand Down
2 changes: 1 addition & 1 deletion packages/renderer/src/options/folder-expiry.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const folderExpiryOption = {
docLink: 'https://www.remotion.dev/docs/options/enable-folder-expiry',
type: false as boolean | null,
getValue: ({commandLine}) => {
if (commandLine[cliFlag] !== undefined) {
if (commandLine[cliFlag] !== undefined && commandLine[cliFlag] !== null) {
return {
source: 'cli',
value: commandLine[cliFlag] as boolean | null,
Expand Down
Loading