Skip to content

chore: move the SDK root to pnpm #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jordividaller wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore: move the SDK root to pnpm #1458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
52e08fa
chore: move the SDK root to pnpm
Oct 7, 2026
f405844
ci: install the SDK root with pnpm
Oct 7, 2026
0b8aa94
chore(scripts): use pnpm in release and worktree scripts
Oct 7, 2026
4d38286
chore: ignore a root package-lock.json (PBYR-4975)
Oct 8, 2026
d459d95
docs(scripts): use pnpm in the seed-onboarding usage (PBYR-4975)
Oct 8, 2026
3fa0f89
fix(example): keep the Vercel deploys building with a pnpm root (PBYR…
Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 32 additions & 12 deletions .github/workflows/ci-main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,22 +14,26 @@ jobs:
with:
persist-credentials: false

- name: Enable Corepack
run: corepack enable

- name: Use Node.js
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7
with:
node-version: '24.15.0'
cache: 'pnpm'

- name: Install dependencies
run: npm ci --include=optional --ignore-scripts
run: pnpm install --frozen-lockfile --ignore-scripts

- name: Run format check
run: npm run check-format
run: pnpm run check-format

- name: Run lint
run: npm run lint
run: pnpm run lint

- name: Run type check
run: npm run type-check
run: pnpm run type-check

build-and-exports:
name: Build and Check Exports
Expand All @@ -39,19 +43,23 @@ jobs:
with:
persist-credentials: false

- name: Enable Corepack
run: corepack enable

- name: Use Node.js
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7
with:
node-version: '24.15.0'
cache: 'pnpm'

- name: Install dependencies
run: npm ci --include=optional --ignore-scripts
run: pnpm install --frozen-lockfile --ignore-scripts

- name: Build
run: npm run build
run: pnpm run build

- name: Check exports
run: npm run check-exports
run: pnpm run check-exports

tests:
name: Unit Tests
Expand All @@ -61,16 +69,20 @@ jobs:
with:
persist-credentials: false

- name: Enable Corepack
run: corepack enable

- name: Use Node.js
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7
with:
node-version: '24.15.0'
cache: 'pnpm'

- name: Install dependencies
run: npm ci --include=optional --ignore-scripts
run: pnpm install --frozen-lockfile --ignore-scripts

- name: Run tests
run: npm run test
run: pnpm run test

example-checks:
name: Example App Checks
Expand All @@ -80,16 +92,20 @@ jobs:
with:
persist-credentials: false

- name: Enable Corepack
run: corepack enable

- name: Use Node.js
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7
with:
node-version: '24.15.0'
cache: 'pnpm'

- name: Install main package dependencies
run: npm ci --include=optional --ignore-scripts
run: pnpm install --frozen-lockfile --ignore-scripts

- name: Build main package
run: npm run build
run: pnpm run build

- name: Install example dependencies
working-directory: ./example
Expand Down Expand Up @@ -171,13 +187,17 @@ jobs:
with:
persist-credentials: false

- name: Enable Corepack
run: corepack enable

- name: Use Node.js
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7
with:
node-version: '24.15.0'
cache: 'pnpm'

- name: Install main package dependencies
run: npm ci --include=optional --ignore-scripts
run: pnpm install --frozen-lockfile --ignore-scripts

- name: Install example/ dependencies
working-directory: ./example
Expand Down
16 changes: 12 additions & 4 deletions .github/workflows/coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,20 @@ jobs:
with:
persist-credentials: false

- name: Enable Corepack
run: corepack enable

- name: Use Node.js
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7
with:
node-version: '24.15.0'
cache: 'pnpm'

- name: Install dependencies
run: npm ci --include=optional --ignore-scripts
run: pnpm install --frozen-lockfile --ignore-scripts

- name: Run tests with coverage
run: npm run test:coverage
run: pnpm run test:coverage

- name: Upload coverage artifacts
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
Expand All @@ -40,13 +44,17 @@ jobs:
with:
persist-credentials: false

- name: Enable Corepack
run: corepack enable

- name: Use Node.js
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7
with:
node-version: '24.15.0'
cache: 'pnpm'

- name: Install dependencies
run: npm ci --include=optional --ignore-scripts
run: pnpm install --frozen-lockfile --ignore-scripts

- name: Download coverage artifacts
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
Expand All @@ -57,7 +65,7 @@ jobs:
- name: Extract coverage percentage
id: coverage
run: |
COVERAGE_JSON=$(npm exec tsx scripts/extract-coverage.ts --coverage-dir coverage)
COVERAGE_JSON=$(pnpm exec tsx scripts/extract-coverage.ts --coverage-dir coverage)
COVERAGE=$(echo "$COVERAGE_JSON" | node -pe "JSON.parse(require('fs').readFileSync(0, 'utf-8')).lines.pct.toFixed(2)")
echo "coverage=$COVERAGE" >> $GITHUB_OUTPUT
echo "Coverage: $COVERAGE%"
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/e2e-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,17 @@ jobs:
with:
persist-credentials: false

- name: Enable Corepack
run: corepack enable

- name: Use Node.js
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7
with:
node-version: '24.15.0'
cache: 'pnpm'

- name: Install main package dependencies
run: npm ci --include=optional --ignore-scripts
run: pnpm install --frozen-lockfile --ignore-scripts

- name: Install example/ dependencies
working-directory: ./example
Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/openapi-codegen-smoke-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
pull_request:
paths:
- 'package.json'
- 'package-lock.json'
- 'pnpm-lock.yaml'

permissions:
contents: read
Expand All @@ -19,14 +19,17 @@ jobs:
with:
persist-credentials: false

- name: Enable Corepack
run: corepack enable

- name: Setup Node.js
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7
with:
node-version: '24.15.0'
cache: 'npm'
cache: 'pnpm'

- name: Install dependencies
run: npm ci --include=optional --ignore-scripts
run: pnpm install --frozen-lockfile --ignore-scripts

- name: Run openapi-ts against the production gateway
run: npm run openapi-ts
run: pnpm run openapi-ts
Loading
Loading