Sign-in renders in the app's language: ui_locales on the authorize request - #1225
Open
JamieRuderman wants to merge 1 commit into
Open
JamieRuderman wants to merge 1 commit into
JamieRuderman wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oidcStartsendspromptandlogin_hintbut nothing about language. This addsui_locales— the language the app is showing (i18n.resolvedLanguage: the per-account override once signed in, else the OS language) — the standard OIDC way to ask the sign-in page to render in it.One line, no behaviour change today: Permitteer accepts the param on
/authorizeand drops it at the next hop (/login?tx=doesn't carry it and the transaction doesn't store it), so the sign-in page keeps following the login window'sAccept-Language— the OS language, which is what the app shows unless the person overrode it. Carrying it across the hop is a schema change on Permitteer's side (a column onConsentTransaction), raised with Evan in ebbtech/permitteer#24 and built oni18n/ui-locales-tx; when it lands, this line is what makes the page follow the app. WithLANGUAGE_PICKER=falseon our deployment there is no picker either way.