Repository navigation
feat: add Shell to assemble a complete application - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by mau
Before: an application had to nest
KeymapProvider,StatusProvider, andPaneFocusProviderin the right order and wire up the status bar, hints, help, and quit keys itself.After:
<Shell title="…">does all of that. Children are usually aSplitofPanes. Quit keys, the help key, the status label (by default the focused pane's id), extra status content, and hints are all props, andinteractive={false}prints a single frame. The demo is rebuilt on it, which is what relay-dash will start from.How:
Shellcomposes the existing providers andShellFrame; nothing below it changed. Reference indocs/api.md, README rewritten aroundShell, with tests.Stacked on the status bar PR; merge that first.