Repository navigation
fix: keep multibyte characters split across output chunks - #3
Merged
Merged
Conversation
Child output arrives in arbitrary byte chunks, and decoding each chunk on its own turned a character split at a chunk boundary into replacement characters. Decode with a streaming UTF-8 decoder instead.
autoantohaki
force-pushed
the
fix/split-utf8-characters
branch
from
October 21, 2026 21:45
d7a253c to
9025eaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by mau
Before: When a child process writes non-ASCII text such as
café ✓, and a pipe chunk boundary falls inside a character, that character shows up as replacement characters (�) on the card.After: The text is shown correctly no matter where the chunk boundary falls.
How:
LineBuffernow decodes buffers with Node's streamingStringDecoderand flushes any remaining bytes inflush(). The new test fails against the old code and passes with this change.