Skip to content

test : Set Up Automated Unit and Integration Test Suite (closes #1334) - #1345

Closed
Pratikshya32 wants to merge 1 commit into
reframe-oss:mainfrom
Pratikshya32:chore-fix-issue-1334
Closed

Pratikshya32 wants to merge 1 commit into
reframe-oss:mainfrom
Pratikshya32:chore-fix-issue-1334

Conversation

@Pratikshya32

Copy link
Copy Markdown

Summary

  • Add integration tests verifying controller logic and thresholds
  • Set up validation checks for configuration schemas

Closes #1334

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@vercel

vercel Bot commented May 28, 2026

Copy link
Copy Markdown

@Pratikshya32 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Pratikshya32

Copy link
Copy Markdown
Author

Hello! I have created a pull request resolving this issue: #1345.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ PR Format Issues — @Pratikshya32

Please fix the following before your PR can be reviewed:

  • ⚠️ Use a conventional PR title. Examples:
    • feat: add dark mode support
    • fix: resolve aria label missing on slider
    • docs: add deployment guide to README

Push new commits after fixing — this comment will update automatically.

📖 CONTRIBUTING.md

@github-actions github-actions Bot added level:beginner Beginner level - 20 pts type:testing Testing labels May 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @Pratikshya32!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@magic-peach magic-peach added the status:awaiting-review Clean PR waiting on a maintainer, not the author label Aug 14, 2026
@magic-peach

Copy link
Copy Markdown
Collaborator

Thanks for the contribution! Another open PR (#1760: test: Set up automated integration tests for useVideoEditor core controller #1334) tackles the same issue and is a bit further along (cleaner CI / no merge conflicts), so I'm consolidating there to keep review focused in one place. Closing this one — no reflection on the work itself, just avoiding split review across duplicates. Feel free to bring anything over to #1760 if it adds something that one doesn't have yet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:beginner Beginner level - 20 pts status:awaiting-review Clean PR waiting on a maintainer, not the author type:testing Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Set up automated unit and integration test suite for reframe core controllers

2 participants