Skip to content

fix: enforce -t flag on export to prevent infinite loop with backgrou… #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magic-peach merged 2 commits into from
Sep 15, 2026
Merged

fix: enforce -t flag on export to prevent infinite loop with backgrou… #1289

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35dd233
fix: enforce -t flag on export to prevent infinite loop with backgrou…
shahabhilash May 27, 2026
17bd969
Merge remote-tracking branch 'origin/main' into fix/infinite-export-loop
magic-peach Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/lib/ffmpeg.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,13 +614,12 @@ interface PositionCoords {
if (shouldKeepAudio) args.push("-c:a", "aac", "-b:a", "128k");
}

// Add explicit output duration when speed != 1 to prevent slight duration
// overshoot caused by encoder/filter pipeline frame flush at stream end.
if (recipe.speed !== 1) {
const sourceDuration = (recipe.trimEnd ?? videoDuration) - recipe.trimStart;
const outputDuration = sourceDuration / recipe.speed;
args.push("-t", outputDuration.toFixed(6));
}
// Add explicit output duration to prevent slight duration overshoot
// caused by encoder/filter pipeline frame flush at stream end,
// and to prevent infinite loops when adding looped audio to silent videos.
const sourceDuration = (recipe.trimEnd ?? videoDuration) - recipe.trimStart;
const outputDuration = sourceDuration / recipe.speed;
args.push("-t", outputDuration.toFixed(6));

args.push(outputName);
return args;
Expand Down