Skip to content

fix: panic when spec omits session ticket extension #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thesinakamali wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −0
Open

fix: panic when spec omits session ticket extension #418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions u_conn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,14 @@ func (uconn *UConn) uLoadSession() error {
return err
}
if session.version == VersionTLS12 {
// [uTLS] Without a session ticket extension there is nowhere to
// put the TLS 1.2 ticket. initSessionTicketExt below would skip
// initialization and leave the controller in NoSession, and the
// following setSessionTicketToUConn would then fail its state
// assertion. Skip resumption instead.
if uconn.sessionController.sessionTicketExt == nil {
return nil
}
// We use the session ticket extension for tls 1.2 session resumption
uconn.sessionController.initSessionTicketExt(session, hello.sessionTicket)
uconn.sessionController.setSessionTicketToUConn()
Expand Down
Loading