Skip to content

Update native Brotli and dr_libs - #90

Merged
refaim merged 1 commit into
masterfrom
codex/issue67-native-deps
Nov 12, 2026
Merged

refaim merged 1 commit into
masterfrom
codex/issue67-native-deps

Conversation

@refaim

@refaim refaim commented Nov 12, 2026 •

Copy link
Copy Markdown
Owner

Updates the pending native Brotli and dr_libs dependencies from the dependency dashboard (#67).

Godot's Brotli path still used the vulnerable 1.2.0 decoder. It now selects 1.2.1 from the official vcpkg registry at 61d7eaeb094a6acbc23d9c2e54de9208175fda47, scoped to Brotli alone; all other registry packages keep the qualified 2026.10.16 baseline. The Godot patch version is 1.2.2 and its release notes describe the security fix.

The MP3 probe and WAV writer keep their existing interfaces and use the exact dr_libs snapshot f12e197fd462e4c22873fbd70d11b1d2f2c1dc3c. Header hashes, source archive identities and existing scoped license metadata are updated. This is a pinned development snapshot, rather than a claim that the two headers are stable tagged releases.

Validation before required CI:

  • 110 focused Python tests pass; the new test helper has full measured line and branch coverage.
  • Independent source review has zero comments.
  • Both native architecture probes reject the previous Brotli 1.2.0 library; the version probe processes no compressed input.
  • Corrected project-local restoration freshly builds both updated packages for both architectures, followed by successful Brotli 1.2.1 and MP3 probes. The full MSVC native test suites pass on x64/x86 in Debug and Release, including the standard Debug fatal-cleanup checks.
  • All 189 existing license-pipeline tests also pass, including their historical synthetic inputs and dynamic-upgrade cases.
  • The new MP3 test owns its decoder context on the heap. The existing MSVC stack limit stays unchanged; selected-file analysis with warnings as errors and both focused native cases pass on x64/x86 after this refinement.
  • Four historical scanner fixtures remain unchanged. Exactly three expectations derived from identical source text are labelled as derived and have independent positive and negative controls. Required CI runs the real ORT/ScanCode audit on the new artifacts.

@codecov

codecov Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (0df3078) to head (e70ac9d).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #90   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           74        74           
  Lines        10318     10318           
  Branches      2351      2351           
=========================================
  Hits         10318     10318           
Flag Coverage Δ
native-x64 100.00% <ø> (ø)
native-x86 100.00% <ø> (ø)
python 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Select the fixed Brotli 1.2.1 decoder through an official package-specific
vcpkg registry and pin the used dr_libs headers to the qualified f12e197 snapshot.
Advance the Godot patch version and bind license metadata to the new source bytes.

Preserve historical scanner observations and explicitly label the three
source-equivalent expectations derived from them. Cover qualified decoder
selection and incomplete MP3 input with native regression checks.
Keep the test decoder context on the heap within the existing stack-analysis limit.

Co-Authored-By: Codex (gpt-6.1-sol) <noreply@openai.com>
@refaim
refaim force-pushed the codex/issue67-native-deps branch from e6241f1 to e70ac9d Compare November 12, 2026 09:53
@refaim
refaim merged commit d5cf614 into master Nov 12, 2026
31 checks passed
@refaim
refaim deleted the codex/issue67-native-deps branch November 12, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant