Repository navigation
Update native Brotli and dr_libs - #90
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #90 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 74 74
Lines 10318 10318
Branches 2351 2351
=========================================
Hits 10318 10318
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Select the fixed Brotli 1.2.1 decoder through an official package-specific vcpkg registry and pin the used dr_libs headers to the qualified f12e197 snapshot. Advance the Godot patch version and bind license metadata to the new source bytes. Preserve historical scanner observations and explicitly label the three source-equivalent expectations derived from them. Cover qualified decoder selection and incomplete MP3 input with native regression checks. Keep the test decoder context on the heap within the existing stack-analysis limit. Co-Authored-By: Codex (gpt-6.1-sol) <noreply@openai.com>
refaim
force-pushed
the
codex/issue67-native-deps
branch
from
November 12, 2026 09:53
e6241f1 to
e70ac9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the pending native Brotli and dr_libs dependencies from the dependency dashboard (#67).
Godot's Brotli path still used the vulnerable 1.2.0 decoder. It now selects 1.2.1 from the official vcpkg registry at
61d7eaeb094a6acbc23d9c2e54de9208175fda47, scoped to Brotli alone; all other registry packages keep the qualified2026.10.16baseline. The Godot patch version is 1.2.2 and its release notes describe the security fix.The MP3 probe and WAV writer keep their existing interfaces and use the exact dr_libs snapshot
f12e197fd462e4c22873fbd70d11b1d2f2c1dc3c. Header hashes, source archive identities and existing scoped license metadata are updated. This is a pinned development snapshot, rather than a claim that the two headers are stable tagged releases.Validation before required CI: