Repository navigation
test(search): cover title edge cases in session title resolution - #453
Merged
rnambaale merged 1 commit intoOct 17, 2026
Merged
Conversation
Adds mock tests for resolve_session_titles covering a whitespace-only session title (falls back to the date), a title with surrounding spaces (returned trimmed), a mixed batch of titled, untitled and unknown ids in one call, and duplicate ids in the input. Refs #431. Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
[Low impact] This test-only PR appears safe to merge. SummaryAdds four mock-backed tests for
Reviews (1) · Last reviewed commit: "test(search): cover title edge cases in ..." · Reviewed by Greptile |
rnambaale
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #431
What
Adds four mock-backed edge-case tests for
resolve_session_titles. No production code changes.Why
Issue #431 asks that the title query stay out of the domain layer and that the fallback title behave correctly. The layering fix is already on the base branch (
0a67ca9e, PR #420). These tests pin the edge cases the existing tests skipped.How
Adds to
entity_api/src/search/session_title_mock_tests.rs:Coaching session — YYYY-MM-DD.Testing
cargo test -p entity_api --features mock session_title: 8 of 8 pass (4 existing, 4 new).cargo test -p domain -p web --features "domain/mock,web/mock" search: domain 10 pass, web 15 pass.cargo fmt --all -- --checkandcargo clippy -p entity_api --all-targets --features mock -- -D warnings: clean.Blast radius
Test-only. Stacked on #420, so this PR's diff is one commit on top of that branch. Merge after #420 or retarget to main once #420 lands.
Gotchas
feat/search-keyword-core, notmain.Generated with Claude Code