Repository navigation
Block monthly series that start after the 28th - #491
Merged
Merged
Conversation
jhodapp
marked this pull request as ready for review
October 20, 2026 21:09
Contributor
[Medium impact] The PR appears safe to merge. SummaryAdds a shared check that blocks monthly series starting after the 28th in the user's timezone.
No actionable issues found. Review was based on source inspection; tests were not run. Reviews (1) · Last reviewed commit: "docs(test-plans): daylight saving cases ..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Frontend half of the series daylight saving fix. Monthly series can no longer start on the 29th, 30th or 31st, which the backend now rejects. The manual test plan gains daylight saving cases.
Pairs with refactor-group/refactor-platform-rs#455.
Changes
validateRecurrencereturns "Monthly sessions can't start on the 29th, 30th or 31st. Pick the 28th or earlier." when the first session's local day is after the 28th. The create form and the reschedule-series dialog both use it, so submit stays disabled.docs/test-plans/resend_calendar_invite_manual_testing.md: Part D (D1–D6) covers series across a daylight saving change, checked in Google Calendar. Cleanup now deletes through the dashboard, so cancellations are checked too.Screenshots / Videos Showing UI Changes (if applicable)
Helpful: the create dialog with Monthly on the 30th, showing the message and the disabled button.
Testing Strategy
npm run test: 2207 pass. Newrecurrence.test.tscases cover days 29–31, the 28th, weekly/daily on the 31st, and local versus UTC day (Chicago and Tokyo). Switching the check to the UTC day fails them.Concerns
None. No wire change.