DEV-3362: loyalty methods#214
Merged
Merged
Conversation
Empty popular_links/categories/brands is a valid response (the shop may have none configured) and the model already handles it gracefully. Assert only the parsing contract: if items exist, each must have a non-empty name and url. Removes coupling of the test to a specific shop's content.
Item 486 is not in the integration test shop's catalog, so the subscribe/unsubscribe price-drop and back-in-stock tests failed with HTTP 400 'Item not found'. Switch testItemId to 300275, which exists in the shop, making all 16 subscription tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.