Repository navigation
release: version the Windows setup asset name for the launcher - #118
Merged
Merged
Conversation
The Inno Setup installer was published as `redrob-code-x64-setup.exe`, the
one release asset without a version or an OS token. It now follows the
`<repo>-<version>-<os>-<arch>-setup.exe` shape Redrob Launcher parses, e.g.
`redrob-code-0.6.8-windows-x64-setup.exe`, like the MSIs and portable zips
beside it.
- installer/windows/redrob-code.iss: OutputBaseFilename takes {#AppVersion},
which the workflow already passes as /DAppVersion.
- release.yml: the existence check, the signing list and the artifact upload
reference the versioned name; signing still reads the same path list.
- installation/index.ts: the upgrade hint names the versioned file.
- The two existing tests that pinned the old name are updated.
The `redrob-<platform>.zip|tar.gz` CLI archives are untouched: the install
script, publish.ts (AUR/Homebrew) and the launcher-assets packer read them.
Member
Author
|
Self-review: the only behavioural change is the file name the Inno Setup build emits and the three workflow references to it (existence check, signing list, artifact upload), all driven by the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's done
redrob-code-<version>-windows-x64-setup.exe(e.g.redrob-code-0.6.8-windows-x64-setup.exe) instead ofredrob-code-x64-setup.exe. This is the<repo>-<version>-<os>-<arch>-setup.exeshape Redrob Launcher'sparse_asset_nameaccepts, and it matches the MSIs and portable zips released beside it.installer/windows/redrob-code.iss:OutputBaseFilenameuses{#AppVersion}, which the workflow already passes via/DAppVersion..github/workflows/release.yml: the post-build existence check,REDROB_WINDOWS_INSTALLER(signing list) and therelease-windowsartifact upload reference the versioned name. Signing is unchanged otherwise -- it still receives a path list.packages/redrob/src/installation/index.ts: the "installed by the Windows installer" upgrade hint names the versioned file for the target version.v0.6.8release asset was renamed in place to the new name (andSHA256SUMS.txtadjusted if it listed it) so the latest release already matches.What's not done
redrob-<platform>.zip|tar.gzCLI archives keep their names on purpose: theinstallscript,packages/redrob/script/publish.ts(AUR PKGBUILD + Homebrew formula URLs) andpackages/redrob/script/launcher-assets.ts(the launcher packer, which reads them as input) all depend on them.What to review
release.ymllines aroundREDROB_WINDOWS_INSTALLER, the$setupcheck and therelease-windowsupload: the three places must agree on the exact file name, andneeds.version.outputs.versionis the same value passed to ISCC asAppVersion.redrob-code-x64-setup.exe; nothing in this repo does.Intentions
Make every Redrob Code release asset parseable by the launcher and by a human reading the release page, so the version in the file name equals the tag and the Windows setup exe stops being the one unversioned outlier.