Repository navigation
Use the shared gitflow, Windows signing and release publish - #105
Merged
Merged
Conversation
gitflow.yml is now a verbatim copy of the redrob-labs/.github caller template; the branch-name and back-merge rules live in the organization workflow, which also opens the back-merge pull request, so branch-sync.yml is deleted. The repository's own tag rule moves to tag-hygiene.yml unchanged. Branch types follow the organization list (feat/ instead of feature/). release.yml keeps version resolution, the Bun build, macOS notarization, the Linux archives, the launcher asset copies, the VERSION marker and build provenance. The inline Windows signing recipe (script/sign-windows.ps1 and its read-back steps) is replaced by redrob-labs/.github/actions/sign-windows, called after each azure/login in the same build -> login -> sign order; a failed signature now fails the job instead of degrading to an unsigned release. The publish job is release-publish.yml with publish: true and launcher_manifest: true; because this release is dispatch-driven, a tag job pushes the annotated tag first and the tag and commit are passed to the shared job explicitly.
Member
Author
|
Dry run on this branch: run 38607867344 -- version, build, sign-macos, sign-windows, assets all green; tag and publish skipped (dry_run=true). Windows job log, from the shared action's read-back: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts this repository to the redrob-labs shared gitflow / signing / publish pieces.
.github/workflows/gitflow.yml: verbatim copy of the organization caller template. Branch names and the back-merge check (gitflow / branch name follows the convention,gitflow / main is contained in develop) are the organization's; the shared job opens the back-merge PR itself, sobranch-sync.ymlis deleted..github/workflows/tag-hygiene.yml: this repository's own tag rule (no workflow pushes tags in bulk), moved out of gitflow.yml unchanged.feature/becomesfeat/in AGENTS.md and docs/BRANCHING.md..github/workflows/release.yml:sign-windows: the inline signing recipe (script/sign-windows.ps1+ read-back steps, deleted) is replaced byredrob-labs/.github/actions/sign-windows, called after eachazure/login(OIDC) in the same build -> login -> sign order, binaries first, installer second. A failed signature or installer build now fails the job instead of degrading to an unsigned release with a warning.assetsjob keeps what only this repository knows: Linux zip/tar.gz, Redrob Launcher asset copies (launcher-assets.ts), theVERSIONmarker install.sh reads, and build provenance. Build jobs uploadrelease-*artifacts.tagjob (skipped on dry run) pushes the annotated tag, exactly as the old publish step did, and prints the promotion link.publishisrelease-publish.yml@mainwithpublish: true,launcher_manifest: true, andtag/targetpassed explicitly because the release is dispatch-driven; itsifdoes not depend ongithub.ref_type.bumpinput, tags as state, one pinned sha), the Bun build, macOS signing/notarization, Linux packaging.Behaviour changes to know about
SHA256SUMS.txt(wasSHA256SUMS) and also coversVERSION. No script in this repository reads either file; docs updated.UPSTREAM_VERSION.ARTIFACT_SIGNING_*still produces unsigned files with a warning (shared action), but a failing signature fails the release.Verification
actionlint -shellcheck=clean on release.yml, gitflow.yml, tag-hygiene.yml.bun test test/installation/launcher-assets.test.ts: 7 pass.release.ymlon this branch: see the comment below for the run id and the Windows signing result.