Skip to content

ci(cdn-version-marker): do not read the marker back from the bucket #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
its-janghoon merged 1 commit into from
Oct 14, 2026
Merged

ci(cdn-version-marker): do not read the marker back from the bucket #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions .github/workflows/cdn-version-marker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,11 @@ jobs:
printf '%s\n' "$VERSION" > version
aws s3 cp version "s3://${REDROB_CDN_BUCKET}/code/latest/version" \
--content-type "text/plain" --cache-control "public, max-age=300" --no-progress
# Read it back from the bucket, which is authoritative. The CDN in front has no
# cache-control on the old object, so it may serve the previous marker for up to its
# default TTL (a day); that is reported, not failed, since the bucket is right.
got="$(aws s3 cp "s3://${REDROB_CDN_BUCKET}/code/latest/version" - | tr -d '\n')"
[ "$got" = "$VERSION" ] || { echo "::error::bucket holds '$got', expected '$VERSION'"; exit 1; }
echo "OK s3://${REDROB_CDN_BUCKET}/code/latest/version = $got"
# The CDN key can write the bucket but not read it (HeadObject is 403), so the upload's
# own exit status is the proof. The CDN in front has no cache-control on the old object,
# so it may serve the previous marker for up to its default TTL (a day); that is reported,
# not failed.
echo "OK s3://${REDROB_CDN_BUCKET}/code/latest/version = $VERSION"
cdn="$(curl --fail --silent --location https://cdn.redrob.ai/code/latest/version || true)"
if [ "$cdn" != "$VERSION" ]; then
echo "::notice::cdn.redrob.ai still serves '$cdn'; it refreshes when the cached copy expires."
Expand Down
Loading