fix: relax che-editor ID detection to match any path segment (CRW-11960)#344
fix: relax che-editor ID detection to match any path segment (CRW-11960)#344vrubezhny wants to merge 1 commit into
Conversation
Previously the quick editor ID check hardcoded index 1, assuming the che-editor annotation always had the format "prefix/editor-name/version". This failed when the prefix or version segments were absent. Now all "/"-separated segments are checked against the regex, so values like "che-idea-server", "che-idea-server/latest", or "eclipse/che-idea-server/latest" are all correctly detected. Fixes: https://redhat.atlassian.net/browse/CRW-11960 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com> Assisted-By: Claude Opus 4.6 <noreply@anthropic.com>
📝 WalkthroughWalkthrough
ChangesIDE editor detection
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #344 +/- ##
==========================================
+ Coverage 0.00% 32.42% +32.42%
==========================================
Files 4 111 +107
Lines 26 4565 +4539
Branches 0 861 +861
==========================================
+ Hits 0 1480 +1480
- Misses 26 2883 +2857
- Partials 0 202 +202 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Previously the quick editor ID check hardcoded index 1, assuming the che-editor annotation always had the format "prefix/editor-name/version". This failed when the prefix or version segments were absent.
Now all "/"-separated segments are checked against the regex, so values like "che-idea-server", "che-idea-server/latest", or "eclipse/che-idea-server/latest" are all correctly detected.
Fixes: https://redhat.atlassian.net/browse/CRW-11960
Assisted-By: Claude Opus 4.6 noreply@anthropic.com