feature: added agent rules for clean jetbrains kotlin code#339
Conversation
📝 WalkthroughWalkthroughAdds a Kotlin and JetBrains plugin standards document, links Cursor to it through a symbolic link, and imports it into ChangesKotlin development rules
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
b1bdea4 to
2f73069
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
==========================================
+ Coverage 0.00% 24.55% +24.55%
==========================================
Files 4 104 +100
Lines 26 4414 +4388
Branches 0 846 +846
==========================================
+ Hits 0 1084 +1084
- Misses 26 3156 +3130
- Partials 0 174 +174 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2f73069 to
82ed967
Compare
Signed-off-by: Andre Dietisheim <adietish@redhat.com>
82ed967 to
9d2b139
Compare
rgrunber
left a comment
There was a problem hiding this comment.
If this works for you, then go ahead and merge.
Some suggestions for the future :
- There may be certain things under
Namingthat could be handled more deterministically, using a formatter - I would consider adding some lint based setup for the
Type Safetyrequirements, if possible - There should be a setting in IDEA (I know Eclipse has it) that lets you configure the
Class Structure. For example, you can sort : Types, Static Fields, Static Initializers, Static Methods, Fields, Initializers, Constructors, Methods .
|
@rgrunber good hints, appreciate, will include changes for these. |
|
Not class structure as it is displayed, but the actual generated code. Various formatters support re-ordering all members in a class based on your specification. Eg. eclipse-jdtls/eclipse.jdt.ls#2169 . Rather than telling an LLM, you can just give it the formatter file and maybe some tool to run it and just tell it "Run this at the end to ensure proper formatting". |
|
@rgrunber ok grocked. But then I'd argue that things should be "fixed" as early as possible in the chain (rahter in the agent than later in the formatter). Of course being a statistical machine agents wont always respect your rule and that's why I'd want a (deterministic) formatter on top. |
provides rules for clean kotlin/jetbrains plugin code when using claude code and cursor