Repository navigation
0.3.2: follow an avatar URL's redirects only within its origin - #2
Merged
Merged
Conversation
The package-folder check covers the paths a package declares, not where a redirect goes, so a public host could redirect requests to an internal one. Redirects are now followed manually, at most 5, and only within the same origin. github.com/.../raw/... links, which redirect to raw.githubusercontent.com, get an error naming the final URL. Found in review of receptron/mulmocast-cli#1598. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadAvatar(url)used to follow any redirect. The package-folder check limits the paths a package declares, but not where a redirect goes, so a public host could redirect requests to an internal service.github.com/.../raw/...links redirect toraw.githubusercontent.com, so use the latter; the README says so.Found in CodeRabbit's review of receptron/mulmocast-cli#1598, which applies the same rule to its cache-stamp requests.
Test plan
npm run lint,npm run typecheck,npm test(59 tests), package smokeraw.githubusercontent.comloads (22 assets). Thegithub.com/.../raw/...form gets the "use the final URL" error.🤖 Generated with Claude Code
work in mesh-avatar-studio