Answer-quality fixes (review, area 3) - #315
Merged
Merged
Conversation
- Disease-variant keyword search indexes the 12 columns the vector store embedded, not all 21: the two retrievers never returned the same text for a variant, so RRF never fused them and results came back doubled. On the real bundle: 300 of 300 vector documents now match BM25 text (0 of 300 before). - Disease-variant citations are labelled with their variant; they had no display_name and went out empty. - A failed post-answer step (grader or web search) is logged and dropped; it failed a turn whose answer had already streamed and been saved. - A model refusing the safety check's structured output is an unsafe verdict, so the reader gets the polite refusal, not an error. - The user-guide prompt carries the language instruction. Measured, three runs each: French 0/3 -> 3/3 answered in French; Spanish and English unchanged. Answer sweep 16/16. - The classifier test that compared a prompt with itself is replaced by one that fails when the no-MCP prompt mentions live services. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These come from the max-level review of the agent and retrieval code. Each one was reproduced by the reviewer.
EMBEDDED_CONTENT_COLUMNS: keyword search indexes the embedded columns, limited to those present in the filevariantmetadataOpenAIRefusalErroris treated as an unsafe verdictLANGUAGE_INSTRUCTION, in the same place as the Reactome prompt./checks.shpasses.🤖 Generated with Claude Code