Bound what one guest can make the chat hold or compute (review, area 2) - #309
Merged
Merged
Conversation
- The typed-yes check ran an unbounded, backtracking pattern on the raw message on the shared event loop: one offer plus 'y' and a million spaces stalled every session for about 90 minutes. Messages over 40 characters are not a yes, and the pattern is possessive. - Messages over 60K are declined, and questions to the model over 8K: a million-character message was kept in the thread's checkpoints and sent to the model on every later turn. - Chainlit keeps every incoming message in a per-session list that is never cleared, rejected ones included. Nothing here reads it; it is now dropped after each message and when the session ends. - A finished guest session's graph thread, offers and seed state are deleted; guests cannot resume, and MemorySaver kept them until restart. - Gene-list seeds and offers keep at most 8K of the message and the identifiers that can be submitted (3,000), not the whole 60K and all. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These come from the max-level review of the chat flow. Each was reproduced by the reviewer.
"y" + 990K spaces, would stall the shared event loop for about 90 minutes.chat_contexts[session]forever, including rate-limited ones.on_chat_endfor guests, who cannot resumeThe GSA validator problems (unbounded work on the event loop, encoding, R headers, CSV) will be in the GSA PR.
./checks.shpasses. The gene-list browser suite passes.🤖 Generated with Claude Code