Repository navigation
Leave the risk T005 was written for open, because it is - #266
Merged
Merged
Conversation
T005a is checked and the classifier risk is not handled, which is the state most likely to be misread. A register that says "handled" is why nobody looks again -- and a classifier that never selects a collection produces confident plausible answers rather than an error anyone notices. T005b records it as open with what closing it would take: the routing distribution observed over real traffic, or a periodic probe. Neither is a test, which is why it cannot be checked off by adding one. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A one-line follow-up to #263 that missed the merge — I pushed it moments after you merged, so it sat stranded on the branch. Caught by checking that it actually landed rather than trusting that the push succeeded.
T005a is checked and the classifier risk is not handled, which is the state most likely to be misread. T005a catches a plumbing failure — a collection unreachable through a name mismatch or a lookup that yields nothing. A classifier that never chooses a collection is undetectable by any deterministic test, and it produces confident, plausible, wrong answers rather than an error anyone notices.
Closing it needs the routing distribution observed over real traffic, or a periodic probe asking known-collection questions and checking what was selected. Neither is a test, which is why it cannot be checked off by adding one.
The wording is deliberate about the register itself: a risk list that reads "handled" is the mechanism by which nobody looks again.
Documentation only.
🤖 Generated with Claude Code