Repository navigation
Ship the Reactome welcome screen; mount the Plant Reactome one - #199
Merged
Merged
Conversation
main shipped the Plant Reactome welcome text, so the Reactome deployment greeted users with a screen naming the wrong knowledgebase -- "your interactive chatbot for exploring Plant Reactome!" on reactome.org. chainlit renders chainlit.md from CHAINLIT_APP_ROOT at startup, and /app is read-only in the image, so there is nothing for the application to choose at runtime. The deployment selects instead: the image ships the Reactome page, and Plant Reactome mounts chainlit.plantreactome.md over it, exactly as config.yml is already overridden. compose.yaml carries the commented mount line for both services. The Reactome text is the one from the security-improvements branch, which is where it had been sitting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main shipped the Plant Reactome welcome text, so the Reactome deployment greeted users with a screen naming the wrong knowledgebase:
…on reactome.org.
The mechanism
chainlit renders
chainlit.mdfromCHAINLIT_APP_ROOTat startup, and/appis read-only in the image now — so there is nothing for the application to choose at runtime, and no flag to read. The deployment selects instead:chainlit.md— the Reactome pagechainlit.plantreactome.mdover itexactly as
config.ymlis already overridden.compose.yamlcarries the commented mount line for both the authenticated and guest services:# - ./chainlit.plantreactome.md:/app/chainlit.md:roNo code, which is the right amount for this.
Pinned
Six tests: both files exist, the shipped default names Reactome and not Plant Reactome, the variant names Plant Reactome, the Dockerfile ships the default and not the variant (shipping both would make it ambiguous which is in effect), and neither is empty — chainlit reads an empty
chainlit.mdas "no welcome screen at all".The Reactome text is the one that had been sitting on
security-improvements.