Repository navigation
Record the ragas metrics deprecation and why it is not a rename - #196
Merged
Merged
Conversation
Every evaluator run warns that ragas.metrics is deprecated in favour of ragas.metrics.collections. Reading that as an import change is wrong: two of the four are renamed, and the new classes take the judge as a constructor argument rather than through evaluate(), so a straight swap raises TypeError. Moving is a rework that may also move the scores. Written down because the warning invites a rename that does not work, and because the cheapest moment to change scoring is before anyone is comparing against the numbers -- which is now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every
./bin/evaluaterun warns:Reading that as an import change is wrong, and I checked rather than assuming:
ResponseRelevancy→AnswerRelevancy,LLMContextRecall→ContextRecallevaluate():So it is a rework of how metrics are built, and it may move the scores — which for a measurement tool is the part needing care, not the import.
Recorded rather than done, because it is a small project and not a rename. Noted also that the cheapest moment to change scoring is before anyone is comparing against the numbers, which is now.