Repository navigation
Make bin/evaluate and bin/probe_model_temperature run as documented - #192
Merged
Merged
Conversation
Both scripts landed today carrying a usage line -- `./bin/evaluate`, `./bin/probe_model_temperature` -- that raises ModuleNotFoundError. Imports resolved in the Dockerfile (PYTHONPATH=/app/src) and in CI (./bin:./src) and nowhere else, so the documented invocation was the one configuration nobody had run. Found by running the command in the README rather than the one used while developing. Each script now puts src/ on sys.path itself, from its own location, so it works from any directory. poetry run is still needed for the interpreter, and the README now says so. bin/probe_model_temperature also took --help as a model name and dutifully probed a model called "--help". It prints its docstring now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both scripts landed today carry a usage line that does not work:
Imports resolved in the Dockerfile (
PYTHONPATH=/app/src) and in CI (./bin:./src) — and nowhere else. So the invocation printed in the README was the one configuration nobody had actually run. I found it by running the command as written rather than thePYTHONPATH=./src:./bin .venv/bin/python bin/evaluateI had been using while developing.Each script now puts
src/onsys.pathfrom its own location, so it works from any directory.poetry runis still needed for the interpreter, and the README says so.bin/probe_model_temperaturealso treated--helpas a model name and dutifully probed a model called--help. It prints its docstring now.Verified: both
--helpinvocations, andbin/evaluaterun from/tmp.Note the same pattern affects
bin/retrieval_baselineandbin/embeddings_manager, whose docstrings show bare./bin/...invocations too. Left alone here rather than widening the diff — worth a follow-up.