Skip to content

Run poetry-check on push to main, so main stops showing 6/8 #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamjohnwright merged 2 commits into from
Sep 9, 2026
Merged

Run poetry-check on push to main, so main stops showing 6/8 #184

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56a0440
Run poetry-check on push to main, so main stops showing 6/8
adamjohnwright Sep 9, 2026
eb43609
Merge remote-tracking branch 'origin/main' into fix/poetry-check-on-main
adamjohnwright Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,12 @@ jobs:
run: poetry run pytest

poetry-check:
if: ${{ github.event_name == 'pull_request' || github.event_name == 'workflow_dispatch' }}
# No event filter. It used to run only on pull_request and
# workflow_dispatch, so every push to main skipped it -- and GitHub counts
# a skipped required check as not-passing, leaving main permanently
# showing 6/8. A main branch that always looks amber is a main branch
# nobody reads. The expensive steps stay gated on poetry.lock actually
# having changed, which on a push means comparing against HEAD^.
runs-on: ${{ matrix.os }}
strategy:
matrix:
Expand All @@ -71,8 +76,16 @@ jobs:
shell: bash
run: |
base="${{ github.base_ref }}"
if [ -z "$base" ]; then
# manual run: no base to compare against, so always verify
if [ -z "$base" ] && [ "${{ github.event_name }}" = "push" ]; then
# A push has no base branch; compare against what main was
# before it, so this stays as cheap here as it is on a PR.
if git diff --name-only HEAD^ HEAD -- poetry.lock | grep -q .; then
echo "changed=true" >> "$GITHUB_OUTPUT"
else
echo "changed=false" >> "$GITHUB_OUTPUT"
fi
elif [ -z "$base" ]; then
# workflow_dispatch: nothing to compare against, so verify.
echo "changed=true" >> "$GITHUB_OUTPUT"
elif git diff --name-only "origin/$base...HEAD" -- poetry.lock | grep -q .; then
echo "changed=true" >> "$GITHUB_OUTPUT"
Expand Down
Loading