Avoid util deep imports#706
Conversation
|
@QDyanbing is attempting to deploy a commit to the React Component Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Walkthrough升级 变更依赖升级与 API 对齐
预计代码审查工作量🎯 2 (简单) | ⏱️ ~8 分钟 可能相关的 PR
建议审查者
诗
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates dependencies and refactors imports from @rc-component/util to use named exports instead of deep paths. It also expands the types exported from the main entry point. The reviewer suggested further expanding the exported types to include BeforeUploadFileType, UploadProgressEvent, and others to ensure a complete public API and avoid deep path imports for users.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #706 +/- ##
=======================================
Coverage 89.58% 89.58%
=======================================
Files 6 6
Lines 317 317
Branches 90 94 +4
=======================================
Hits 284 284
Misses 33 33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
变更内容
@rc-component/util到当前 latest^1.11.1。@rc-component/father-plugin到^2.2.0,交由插件统一处理 rc 深路径 import 限制。@rc-component/util/lib/*的引用改为从@rc-component/util根入口导入。AcceptConfig、RcFile、UploadRequestOption等上传相关类型。背景
配合 rc 包统一避免依赖其他 rc 包的
es/lib构建产物内部路径,改为使用公开根入口 API。验证
git diff --checknpm run compile、npm run lint、npm test。Summary by CodeRabbit
发布说明
Chores
其他改进