Repository navigation
review hardening - #589
Merged
Merged
review hardening#589
Conversation
Treat finish_reason=length as an immediate error instead of increasing max_tokens and retrying. Update the test to assert the token limit remains unchanged.
Record request hashes, timings, network errors, HTTP metadata, and response usage in a JSONL log without storing prompts or translations. Document Kimi 504 observations and add coverage for successful and failed responses.
Separate boundary checks and per-page quote collection from `fetch_quotes` to make the pagination loop easier to follow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.