Repository navigation
A Google Drive sync renews its access token, a disconnect spares a grant still in use, and only the connector reconnects - #33
Merged
Conversation
…ant still in use, and only the connector reconnects Signed-off-by: Bogdan Szabo <bogdan@re-cinq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings WaylandYang's review fixes on deeplethe#1386 and deeplethe#1388 into re-dev, ahead of upstream. These are the same changes, taken as a diff so re-dev keeps the fork migration 9006.
A sync renews its access token on a 401 instead of failing every download after an hour. A disconnect revokes at Google only when no other source uses the same account, and checks the response. Only the person who connected can reconnect: everyone else disconnects first, after a confirmation that names whose Drive it is. Creating a Drive source is refused without an OAuth client.
Drive and source tests pass on a fresh database, and the web build and tests pass. Needed before v0.1.0-re.20.