Skip to content

RDKEMW-25984 : Remove GET parameter support to prevent CSRF in ajaxSet_wireless_network_configuration #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrejz2 wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

RDKEMW-25984 : Remove GET parameter support to prevent CSRF in ajaxSet_wireless_network_configuration #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
89b3643
RDKEMW-25984: Remove GET parameter support to prevent CSRF in ajaxSet…
Sep 30, 2026
7a35204
RDKEMW-25984: Trigger fresh CI run to clear stale pr-lint checks
Sep 30, 2026
2f19333
RDKEMW-25984: Trigger fresh CI run to clear stale pr-lint checks
Sep 30, 2026
d4a8861
RDKEMW-25984: Trigger fresh CI run to clear stale pr-lint checks
Sep 30, 2026
e835dc9
RDKEMW-25984: Trigger fresh CI run to clear stale pr-lint checks (retry)
Sep 30, 2026
c5ad65c
RDKEMW-25984: Trigger fresh CI run to clear stale pr-lint checks (fin…
Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions source/Styles/xb6/jst/actionHandler/ajaxSet_wireless_network_configuration.jst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,9 @@ function validFilterParam($ft){
}
if ($_POST['configInfo']) {
$jsConfig = $_POST['configInfo'];
} else if ($_GET['configInfo']){
$jsConfig = rawurldecode($_GET['configInfo']);
} else {
echo('{"error":"configInfo parameter required"}');
exit(0);
}
//$jsConfig = '{"ssid_number":"1", "ft":[["1","2"],["c","d"]], "target":"save_filter"}';
$arConfig = json_decode($jsConfig, true);
Expand Down
5 changes: 3 additions & 2 deletions source/Styles/xb6/jst/actionHandler/ajaxSet_wireless_network_configuration_onewifi.jst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,9 @@ function validFilterParam($ft){
}
if ($_POST['configInfo']) {
$jsConfig = $_POST['configInfo'];
} else if ($_GET['configInfo']){
$jsConfig = rawurldecode($_GET['configInfo']);
} else {
echo('{"error":"configInfo parameter required"}');
exit(0);
}

//$jsConfig = '{"ssid_number":"1", "ft":[["1","2"],["c","d"]], "target":"save_filter"}';
Expand Down
10 changes: 10 additions & 0 deletions tests/ajaxSet_wireless_csrf_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
#!/bin/sh
if grep -q "\$_GET\['configInfo'\]" source/Styles/xb6/jst/actionHandler/ajaxSet_wireless_network_configuration.jst; then
echo "FAIL: GET support still present in ajaxSet_wireless_network_configuration.jst"
exit 1
fi
if grep -q "\$_GET\['configInfo'\]" source/Styles/xb6/jst/actionHandler/ajaxSet_wireless_network_configuration_onewifi.jst; then
echo "FAIL: GET support still present in ajaxSet_wireless_network_configuration_onewifi.jst"
exit 1
fi
echo "PASS: GET support removed from both files"
Loading