Repository navigation
RDKB-67104 : Safely handles missing/empty POST fields - #103
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Apply equivalent missing/empty-field handling to the parallel PHP endpoint.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Improves XB3 save-configuration handling for missing or invalid POST fields.
Changes:
- Adds safe failure defaults and required-field checks.
- Restricts filenames to valid alphanumeric values.
| File | Summary |
|---|---|
source/Styles/xb3/jst/actionHandler/ajaxSet_at_downloading.jst |
Adds safer POST validation; corresponding PHP handling remains unresolved. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
udaybhadauria
approved these changes
Oct 1, 2026
GoutamD2905
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Command Injection tests results in "500 Internal Server Error"
Test Procedure: Test for Save/Restore
Risks: Low
Priority: P1