Repository navigation
RDKB-66188 RDKB-66587 : Parental control reports and Troubleshooting logs issue - #102
Merged
Merged
Conversation
Reason for change: Parental control report not populating Test Procedure: Test for Parental control reports generation Risks: Low Priority: P1
Test Procedure: Test for Parental control reports generation Risks: Low Priority: P1
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Critical log parsing issues remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Updates JST log collection for parental reports and troubleshooting logs.
Changes:
- Captures command output in JST.
- Filters and writes troubleshooting and parental log data to temporary files.
| File | Review |
|---|---|
source/Styles/xb3/jst/actionHandler/ajax_troubleshooting_logs.jst |
Critical: preserves only type: lines, causing malformed or empty troubleshooting responses. |
source/Styles/xb3/jst/actionHandler/ajax_parental_reports.jst |
Critical: filters out required record fields, preventing parental reports from being populated. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Test Procedure: Test for Parental control reports generation Risks: Low Priority: P1
Thanusha-D
changed the title
pavankumar464
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: To populate parental report & troubleshoot logs
Test Procedure: Try to generate report & logs from GUI
Risks: Low
Priority: P1