Repository navigation
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
http/router.go must honor testOnly when selecting token API authentication middleware.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds configurable authentication for the device-token creation API while preserving unauthenticated defaults.
Changes:
- Adds token API authentication configuration and accessors.
- Applies
ApiMiddlewarewhen enabled. - Adds routing, configuration, and accessor tests.
- Documents the new setting.
| File | Summary |
|---|---|
http/webconfig_server.go |
Stores and exposes token API authentication settings. |
http/webconfig_server_test.go |
Tests defaults, middleware behavior, and accessors. |
http/router.go |
Selects authentication middleware for token creation; must honor testOnly. |
config/sample_webconfig.conf |
Documents the new configuration option. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.