Repository navigation
Conversation
add bitmap definitions for hotspotwantolan and ignitewifi
Cherrypick of version update for metrics
Cherrypick kafka stability
replace the tls layer in config key path with flat key names
- Make disable_initial_host_lookup configurable via config key; replace hardcoded constant with dbconf.GetBoolean - Add exponential reconnection policy with configurable initial interval, max retries (default 10), and max interval - Add socket keepalive support via configurable socket_keepalive_sec - Upgrade host selection to TokenAwareHostPolicy wrapping DCAwareRoundRobinPolicy when local_dc is set - Fix TLS host verification: derive EnableHostVerification from insecure_skip_verify instead of hardcoding false - Read insecure_skip_verify once and pass to loadCassandraTLSConfig to eliminate duplicate config reads - Add tls.server_name support for SNI override - Raise default timeouts from 1s to 10s; align sample config - Document all new config keys in sample_webconfig.conf for both cassandra and yugabyte blocks
Improve Cassandra connection resilience and configurability
Developn 1
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
A Cassandra diagnostic-label issue remains, and the change set warrants final human review.
Review effort: Lite
Findings: None
What changed in this PR
This PR hardens JWT validation, centralizes Kafka/Cassandra TLS configuration, and updates routing tests and documentation.
Changes:
- Validates token MACs before capabilities and handles malformed claims safely.
- Shares TLS configuration across Kafka and Cassandra.
- Updates routing tests, README documentation, and sample configuration.
| File | Reviewed changes |
|---|---|
security/token.go |
Improves token validation ordering and claim handling. |
security/token_test.go |
Adds JWT regression tests. |
README.md |
Updates TLS configuration documentation. |
http/webconfig_server_test.go |
Adds test middleware coverage. |
http/router.go |
Updates test and unauthenticated route middleware. |
db/cassandra/cassandra_client.go |
Uses shared TLS configuration; driver-specific diagnostic labeling needs review. |
config/sample_webconfig.conf |
Adds flat TLS and server-name settings. |
common/kafka_tls.go |
Provides shared Kafka/Cassandra TLS loading. |
common/kafka_tls_test.go |
Tests TLS behavior, server names, and cipher suites. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.