RDKCOM-5642: RDKBDEV-3499, RDKBACCL-1878 Adding condition check for Base MAC address - #43
Open
manigandanj wants to merge 1 commit into
Open
manigandanj wants to merge 1 commit into
manigandanj wants to merge 1 commit into
Conversation
manigandanj
force-pushed
the
AddConditionCheck
branch
from
September 8, 2026 09:13
dbfe570 to
f6ab123
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, targeted, and reduces the likelihood of generating an invalid derived MAC when the base MAC is missing.
Pull request overview
Adds a guard in EthLink_GetMacAddr() to fail fast when the base MAC address lookup returns an empty string, preventing computation of an offset MAC from missing base data.
Changes:
- Added an explicit empty-string check on the base MAC address returned by
DmlEthGetParamValues(). - Logs an error and returns failure when the base MAC address is empty.
File summaries
| File | Description |
|---|---|
| source/TR-181/middle_layer_src/ethernet_apis.c | Adds a condition to reject empty base MAC address values before offset/formatting logic. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
manigandanj
changed the title
Reason for change: To avoid addition of trailing MAC address without base MAC address Test procedure: Sanity Risks: Low Signed-off-by: Manigandan Gopalakrishnan <Manigandan_Gopalakrishnan@comcast.com>
manigandanj
force-pushed
the
AddConditionCheck
branch
from
September 8, 2026 09:23
f6ab123 to
13a848b
Compare
pradeeptakdas
changed the title
S-Parthiban-Selvaraj
approved these changes
Sep 18, 2026
S-Parthiban-Selvaraj
left a comment
S-Parthiban-Selvaraj
left a comment
Contributor
There was a problem hiding this comment.
Will be consumed in the next Wan components release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: To avoid addition of trailing MAC address without base MAC address
Test procedure: Sanity
Risks: Low