RDKCOM-5616: RDKBDEV-3470, RDKBACCL-1853: SSH and WebUI not working - Ethernet Configurable WAN by anatar818 · Pull Request #435 · rdkcentral/utopia

anatar818 · 2026-10-01T14:43:18Z

Ecm_wan_name is getting updated causing regression in XB devices

Reason for change: Verify configurable wan interface in BPI R4 (ethagent functionality)
Test Procedure: Build and flash the image ,Validate wan functionality for the customized interface name
Risks: None
Priority : P2

…nterface Integration Reason for change: Verify configurable wan interface in BPI R4 (ethagent functionality) Test Procedure: Build and flash the image ,Validate wan functionality for the customized interface name Risks: None

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Removed redundant copying of WAN interface name to ecm_wan_ifname.

Copilot

Copilot review overview

🟡 Changes recommended

Skipping eCM interface initialization can generate malformed firewall rules and cause firewall restoration to fail.

Review effort: Balanced
Findings: 1

Open (1)

Prevent malformed firewall rules when eCM interface is unsupported · New

What changed in this PR

Updates firewall handling for configurable WAN interfaces to support customized interface names.

Changes:

Adds configurable-WAN fallback interface selection.
Uses the current WAN interface for Ethernet WAN SSH rules.
Conditionally skips loading the eCM WAN interface.

File	Description
`source/firewall/firewall.c`	Updates WAN interface initialization and SSH firewall rules.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Removed conditional compilation for ecm_wan_ifname retrieval.

Copilot

Copilot review overview

🔵 Needs a closer look

Equivalent nftables paths remain unchanged, leaving configurable WAN and SSH broken when nftables is enabled.

Review effort: Balanced
Findings: None

Resolved since last review (1)

Prevent malformed firewall rules when eCM interface is unsupported

Previously missed (2)

In code that hasn't changed since last review

nft backend ignores configured physical WAN interface

source/firewall/firewall.c:2389

This configurable-WAN fallback is only added to the iptables implementation. When nft_enable=1, firewall_log_handle.sh runs firewall_nft, whose prepare_globals_from_configuration() still falls back directly to wan_ifname/erouter0 (source/firewall_nft/firewall_nft.c:2328-2337) and never reads wan_physical_ifname. As a result, the customized interface is still absent from the generated nftables rules. Please mirror this initialization in the nft backend.

nft backend breaks SSH on customized Ethernet WAN

source/firewall/firewall.c:12611

The SSH-interface correction also needs to be applied to the nft backend. In nft mode, the corresponding branch at source/firewall_nft/firewall_nft.c:11448-11458 still selects default_wan_ifname whenever it differs from current_wan_ifname, so SSH remains unavailable on a customized Ethernet WAN interface.

Removed unnecessary blank line in firewall.c

Copilot

Copilot review overview

🟡 Changes recommended

The equivalent nftables path remains unchanged, so the regression persists when nft_enable=1.

Review effort: Balanced
Findings: 1

Open (1)

Mirror configurable-WAN fixes in the nftables firewall backend · New

+#ifdef FEATURE_RDKB_CONFIGURABLE_WAN_INTERFACE
+    if ('\0' == current_wan_ifname[0]) {
+	  char wanInterface[20] = {'\0'};	
+      syscfg_get(NULL, "wan_physical_ifname", wanInterface, sizeof(wanInterface));


Copilot

Copilot review overview

🔵 Needs a closer look

The equivalent nftables path remains unfixed when nft_enable=1.

Review effort: Balanced
Findings: 1

Open (1)

Mirror configurable-WAN fixes in the nftables firewall backend

anatar818 and others added 15 commits July 7, 2026 13:29

Update firewall.c

184776e

Merge branch 'develop' into anatar818-patch-2

c1fab5c

Updating the buffer size to fix the build issue

551a8ec

Update firewall.c

a837c5a

Update firewall.c

b3edc78

Merge branch 'develop' into anatar818-patch-2

a9b8cec

Merge branch 'develop' into anatar818-patch-2

ae24d04

Update firewall.c

4296250

Fix snprintf syntax for ecm_wan_ifname assignment

9ba577c

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Merge branch 'develop' into anatar818-patch-2

61f2598

Update firewall.c

7f97dcf

Merge branch 'develop' into anatar818-patch-2

3652a85

Merge branch 'develop' into anatar818-patch-2

d5efb72

Simplify WAN interface name assignment

58fabc9

Removed redundant copying of WAN interface name to ecm_wan_ifname.

Copilot AI balanced review requested due to automatic review settings October 1, 2026 14:43

anatar818 requested review from a team as code owners October 1, 2026 14:43

Copilot started reviewing on behalf of anatar818 October 1, 2026 14:44 View session

Copilot AI reviewed Oct 1, 2026

View reviewed changes

Comment thread source/firewall/firewall.c Outdated

Remove FEATURE_RDKB_CONFIGURABLE_WAN_INTERFACE check

066ba7a

Removed conditional compilation for ecm_wan_ifname retrieval.

Copilot AI balanced review requested due to automatic review settings October 1, 2026 14:47

Copilot started reviewing on behalf of anatar818 October 1, 2026 14:48 View session

Add retrieval of ecm_wan_ifname from syscfg

09b2aa6

Copilot AI reviewed Oct 1, 2026

View reviewed changes

Copilot AI balanced review requested due to automatic review settings October 1, 2026 14:49

Remove blank line in firewall.c

91e180c

Removed unnecessary blank line in firewall.c

Copilot started reviewing on behalf of anatar818 October 1, 2026 14:50 View session

Merge branch 'develop' into anatar818-patch-2

d9c1b00

Copilot AI reviewed Oct 1, 2026

View reviewed changes

Comment thread source/firewall/firewall.c

Comment on lines +2386 to +2389

#ifdef FEATURE_RDKB_CONFIGURABLE_WAN_INTERFACE

if ('\0' == current_wan_ifname[0]) {

char wanInterface[20] = {'\0'};

syscfg_get(NULL, "wan_physical_ifname", wanInterface, sizeof(wanInterface));

Copilot AI balanced review requested due to automatic review settings October 1, 2026 14:52

Copilot started reviewing on behalf of anatar818 October 1, 2026 14:52 View session

Copilot AI reviewed Oct 1, 2026

View reviewed changes

Navigation Menu

RDKCOM-5616: RDKBDEV-3470, RDKBACCL-1853: SSH and WebUI not working - Ethernet Configurable WAN - #435

RDKCOM-5616: RDKBDEV-3470, RDKBACCL-1853: SSH and WebUI not working - Ethernet Configurable WAN#435
anatar818 wants to merge 19 commits into
developfrom
anatar818-patch-2

anatar818 commented Oct 1, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

anatar818 commented Oct 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants