Release 1.10.1 - #418
Merged
Merged
Release 1.10.1#418
Conversation
) * RDKB-65621: Propagate seek-map clearing across log-upload profiles Reason for Change: Fix a race where concurrent profile timeout threads consumed a shared retain-seek flag, causing only one profile to clear its grep seek map after log upload. Store and propagate the clear-seek decision per profile, and update related tests. This ensures all profiles clear their grep seek maps after a log upload, preventing stale seek positions from causing log markers such as Total_5G_clients_split to be missed after log files are truncated or rotated. Test Procedure: Refer the ticket descriptions Risks: Medium Priority: P0 Signed-off-by: Thamim Razith Abbas Ali <tabbas651@comcast.com> * Update scheduler mocks and unit tests for the new per-profile --------- Signed-off-by: Thamim Razith Abbas Ali <tabbas651@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Release 1.10.1 updates the scheduler/log-upload interrupt path so a single “clear seek-map” decision is captured once per LOG_UPLOAD event and propagated consistently to all interrupted profiles, avoiding inter-profile timing races.
Changes:
- Extended
SendInterruptToTimeoutThreadto accept anisClearSeekMapflag and plumbed it through scheduler, bulkdata, and test mocks. - Moved seek-map clearing decision to
ReportProfiles_Interrupt()(compute once, pass to all profiles) and stored it per scheduler profile for the timeout callback. - Updated unit tests/mocks and added a 1.10.1 changelog entry.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| source/test/scheduler/schedulerTest.cpp | Updates test calls for new SendInterruptToTimeoutThread(..., bool) signature. |
| source/test/bulkdata/SchedulerMock.h | Updates mock method signature to include isClearSeekMap. |
| source/test/bulkdata/SchedulerMock.cpp | Updates C-wrapper to forward isClearSeekMap into the mock. |
| source/test/bulkdata/profileTest.cpp | Adjusts expectations for updated interrupt call and new retainseekmap interactions. |
| source/scheduler/scheduler.h | Adds SchedulerProfile::isClearSeekMap and updates interrupt API signature. |
| source/scheduler/scheduler.c | Stores/consumes per-profile isClearSeekMap across interrupt → timeout callback. |
| source/bulkdata/reportprofiles.c | Captures retainseekmap once per interrupt and propagates to all interrupted profiles. |
| source/bulkdata/profile.h | Updates sendLogUploadInterruptToScheduler signature to accept isClearSeekMap. |
| source/bulkdata/profile.c | Passes isClearSeekMap through to scheduler interrupts. |
| CHANGELOG.md | Adds 1.10.1 release entry. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| T2ERROR unregisterProfileFromScheduler(const char* profileName); | ||
|
|
||
| T2ERROR SendInterruptToTimeoutThread(char* profileName); | ||
| T2ERROR SendInterruptToTimeoutThread(char* profileName, bool isClearSeekMap); |
Comment on lines
+7
to
+10
| #### [1.10.1](https://github.com/rdkcentral/telemetry/compare/1.10.0...1.10.1) | ||
|
|
||
| - RDKB-65621: Propagate seek-map clearing across log-upload profiles [`#414`](https://github.com/rdkcentral/telemetry/pull/414) | ||
|
|
Code Coverage Summary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.