RDKEMW-22727 : Fix coverity issues on iarm-event-sender

[balav08]

Reason for change: Fixing coverity reported issues.
Test Procedure: Refer ticket.
Risks: Low
Priority: P2
version: minor

[Copilot]

Pull request overview

This PR addresses a Coverity finding in iarm-event-sender by adding return-value checking for an IARM_Bus_Call made when handling the PeripheralUpgradeEvent.

Changes:

• Captures the return value of IARM_Bus_Call in the PeripheralUpgradeEvent path.
• Logs a warning when the call fails.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

iarm-event-sender/IARM_event_sender.c:547

• memcpy(..., strtok(...), CTRLM_DEVICE_UPDATE_PATH_LENGTH) can read past the end of the token (fixed-length copy from a NUL-terminated string) and will also crash if the payload is missing the expected ':' separator because strtok can return NULL. Also, the result of IARM_Bus_Call is currently only logged; sendIARMEventPayload still returns IARM_RESULT_SUCCESS even when the call fails. Consider validating tokens, using a bounded string copy, and storing the call result in retCode so callers can detect failure.

             memcpy(firmwareInfo.firmwareLocation, strtok(eventPayload, ":"),CTRLM_DEVICE_UPDATE_PATH_LENGTH);
             memcpy(firmwareInfo.firmwareNames, strtok(NULL, ":"),CTRLM_DEVICE_UPDATE_PATH_LENGTH);
             g_message("IARM_event_sender entered case for PeripheralUpgradeEvent : %s and %s\r\n",firmwareInfo.firmwareLocation,firmwareInfo.firmwareNames);

             IARM_Result_t ret = IARM_Bus_Call(CTRLM_MAIN_IARM_BUS_NAME,